Skip to content

Conversation

@iuwqyir
Copy link
Contributor

@iuwqyir iuwqyir commented Apr 16, 2025

TL;DR

Removed memory and Redis storage implementations in favor of using ClickHouse exclusively for storage. Redis and memory are not practical for storing blockchain data and only add maintenance overhead

What changed?

  • Removed the memory storage implementation (internal/storage/memory.go)
  • Removed the Redis storage implementation (internal/storage/redis.go)
  • Removed related configuration options from the codebase
  • Updated the storage connector to only support ClickHouse
  • Updated the example configuration to use ClickHouse for orchestrator storage
  • Removed unused dependencies (go-redis, hashicorp/golang-lru)

How to test?

  1. Verify that the application starts correctly with the updated configuration
  2. Ensure that orchestrator functionality works properly with ClickHouse storage
  3. Check that no errors occur related to missing storage implementations

Why make this change?

This change simplifies the storage architecture by standardizing on ClickHouse as the only storage backend for the orchestrator. This reduces maintenance overhead, simplifies the codebase, and eliminates the need to support multiple storage implementations with different capabilities and limitations.

Copy link
Contributor Author

iuwqyir commented Apr 16, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@iuwqyir iuwqyir requested review from AmineAfia and catalyst17 April 16, 2025 14:16
@iuwqyir iuwqyir marked this pull request as ready for review April 16, 2025 14:16
@iuwqyir iuwqyir merged commit b782c0a into main Apr 17, 2025
5 checks passed
@iuwqyir iuwqyir deleted the 04-16-remove_redis_and_memory_storage_connectors branch April 17, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants